manage.py inspectdb raises TypeError for columns containing '%'

[Andy Terra]

python manage.py inspectdb --database=foo

class Foobar(models.Model):
TypeError: not enough arguments for format string

I've since inspected the database and spotted fields such as...

"PARTIC _(%)_PRÉ"
"Participação_de_Recarga_no_GROSS_(%)"

...which I believe are causing this error.

[Claude Paroz]

I plan to commit first #12460, then it should be easier to fix this one.

[Claude Paroz <claude@…>]

In [f5ea730dac0986b2d48889a2d0fab2c5befb4494]:

Fixed #18843 -- Replaced more special chars in column names (inspectdb)

Thanks airstrike for the report.

[Claude Paroz]

I'm not absolutely sure to have fixed your precise problem. At least, the non-ascii chars stuff is the subject of ticket #16737.

[Anssi Kääriäinen]

This breaks tests on Oracle. Oracle fails to handle the '%' char in table creation at base.py:700. One possible fix here ​https://github.com/akaariai/django/tree/ticket_18843_fix

This is a quick & dirty fix. There might be some deeper problem in the Oracle backend's handling of table creation query strings, but I am too tired to begin inspecting that possibility.

[Claude Paroz]

Is there any other special character in Oracle that is accepted in a table name but would be replaced by re.subn(r'\W', '_', new_name)?

[EmilStenstrom]

Due to the requirement to test this against multiple databases (one being Oracle) and the fact that an existing patch exists, I'm removing easy_pickings from this one. Please revert if you don't agree.

[Shai Berger]

I believe the fix for this problem has already been committed, to master before 1.5 was branched, by @akaariai.

[Aymeric Augustin]

Anssi recently confirmed that the test suite passes on Oracle (+ Python 3, but that doesn't matter here). So it's probably fixed indeed.

[Aymeric Augustin]

In 2249bd275cbae6b73716bf36f5f36def1bb4222e.