#18644 closed Bug (fixed)
django.util.html.urlize fails to trim trailing period when followed by a parenthesis
| Reported by: | ljosa | Owned by: | ljosa |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Users would probably expect
django.utils.html.urlize('(Go to http://www.example.com/foo.)')
to produce
u'(Go to <a href="http://www.ljosa.priv.no/foo">http://www.ljosa.priv.no/foo</a>.)'
and not
u'(Go to <a href="http://www.ljosa.priv.no/foo.">http://www.ljosa.priv.no/foo.</a>)'
as it does at present.
The fix should be easy; I expect to submit a pull request soon.
Change History (6)
comment:1 by , 12 years ago
| Has patch: | set |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:2 by , 12 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The ticket should not be closed until the patch gets committed into Django.
comment:3 by , 12 years ago
| Triage Stage: | Unreviewed → Ready for checkin |
|---|
To me the patch looks good, and the use case valid. Marking as ready for checkin. I will wait a while for comments before committing this.
comment:5 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note:
See TracTickets
for help on using tickets.
Fixed in Pull request 216. I also added a regression test.