https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[xarses@…]

The first two examples should include example file names that the code might be inside, since we might be new to the whole model / view concept.

in ​https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-in-a-view
example is missing import statements for HttpResponseRedirect and render_to_response
example's final return is missing context_instance=RequestContext(request) after the dictionary, or a note needs to be made about this when explaining {% csrf_token %}. import path should also be referenced.

[Aymeric Augustin]

Replying to xarses@…:

The first two examples should include example file names that the code might be inside, since we might be new to the whole model / view concept.

We don't generally include file names in code samples, maybe because Django leaves a lot of flexibility on code layout. You're supposed to have gone through the tutorial first and be familiar with models, views and templates.

---

in ​https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-in-a-view
example is missing import statements for HttpResponseRedirect and render_to_response
example's final return is missing context_instance=RequestContext(request) after the dictionary, or a note needs to be made about this when explaining {% csrf_token %}. import path should also be referenced.

Yes, we should include import paths, and switch to render while we're there.

[xarses]

Replying to aaugustin:

Replying to xarses@…:

The first two examples should include example file names that the code might be inside, since we might be new to the whole model / view concept.

We don't generally include file names in code samples, maybe because Django leaves a lot of flexibility on code layout. You're supposed to have gone through the tutorial first and be familiar with models, views and templates.

Alright, doesn't matter that much, been reading some of the other db examples and they have been saying stuff along the lines of "your model ... {code block}.

Yes I've read the tutorial but still like to get a better idea of what this blob is supposed to represent.

---

in ​https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-in-a-view
example is missing import statements for HttpResponseRedirect and render_to_response
example's final return is missing context_instance=RequestContext(request) after the dictionary, or a note needs to be made about this when explaining {% csrf_token %}. import path should also be referenced.

Yes, we should include import paths, and switch to render while we're there.

[Kevin London]

Fork: ​https://github.com/kevinlondon/django/tree/ticket_18614_1_4

Pull Request: ​https://github.com/django/django/pull/212

[Florian Apolloner <florian@…>]

In [7d06f975fe445f0393455b3eb9ec17dbe04f2ec3]:

Fixed #18614 -- Added missing imports in code samples.

[Kevin London <kevinlondon@…>]

In [c6d06a9453859c5520312454b6353498332ff838]:

[1.4.x] Fixed #18614 -- Added imports and changed render_to_response to render.