Wrong comparison in render method of CheckboxInput class.

[blind]

In line 511 of django.forms.widget, inside the 'render' method of CheckboxInput class, you can see this comparison:

if not (value is True or value is False or value is None or value == ''):

Because in Python the 'is' keyword tests object identity, if value is an object which is emulating a bool type, the comparison wont work.

I think, it should be:

if not (value == True or value == False or value == None or value == ''):

What do you think?

[blind]

patch

[Anssi Kääriäinen]

Doesn't work: 0 == False -> True, 0 is False -> False. The current code relies on this, 0 is wanted as value. Closing this as invalid. The code might use some more comments at least, and if you think you have some backwards compatible solution you want to present, feel free to reopen this ticket.