Opened 13 years ago
Closed 13 years ago
#18033 closed Cleanup/optimization (fixed)
Remove the function-based generic view modules
Reported by: | Aymeric Augustin | Owned by: | nobody |
---|---|---|---|
Component: | Generic views | Version: | dev |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
As explained in the deprecation timeline.
Attachments (3)
Change History (8)
by , 13 years ago
Attachment: | 18033-wip.diff added |
---|
comment:1 by , 13 years ago
Has patch: | set |
---|---|
Needs documentation: | set |
Patch needs improvement: | set |
I think for code and tests, the patch is in good shape (tests pass with SQLite). However there are still mentions of generic views in the documentation. It's not always trivial to update. I will not have time to work on this for the next day at least, so feel free to take the burden :-)
comment:2 by , 13 years ago
Patch needs improvement: | unset |
---|
I think I have now removed all references to function-based reference views.
follow-up: 4 comment:3 by , 13 years ago
My short review of this:
- Tests passed on SQLite.
- I could not find any code references or doc references to the function based generic views.
- The docs can be built.
One warning when building the docs: /home/akaariai/Programming/django/docs/releases/1.3-alpha-1.txt:41: WARNING: Mismatch: both interpreted text role prefix and reference suffix.
A question: there are a lot of .po files referencing the create_update.py - I guess these will be cleared later on?
Apart of the docs warning the patch looks good to me.
comment:4 by , 13 years ago
Thanks a lot for the review. I will fix the warning before the commit.
Replying to akaariai:
A question: there are a lot of .po files referencing the create_update.py - I guess these will be cleared later on?
Yes, when the pot files will be rebuilt, this will automatically disappear.
Remove function-based generic views - WIP