django.contrib.admin.site extra_context

[Riccardo Di Virgilio]

hi, in django.contrib.admin.site the method password_change do not support extra_context, i think it's a minor bug to be fixed.

[Stephen Muss]

Have created a patch and submitted a pull request at ​https://github.com/django/django/pull/64

This is no longer current. A new pull request has been opened at ​https://github.com/django/django/pull/499.

[Stephen Muss]

Tests added to pull request.

[Stephen Muss]

I closed the previous pull request and opened a new one at ​https://github.com/django/django/pull/499.

[lucmult]

Hi,

I didn't understand the use case of this extra_context.

I think the same result it's possible to achieve overwriting the template.

Can you explain better the use case of this new extra_context?

For the patch/pull request:

1 - It'd need to update docs:
​https://docs.djangoproject.com/en/dev/topics/auth/default/#django.contrib.auth.views.password_change

2 - It'd need to update the provided template, currently it's ignoring extra_context

Thanks.

[Tim Martin]

Since the ticket was opened, each_context() has been added to the AdminSite class, so it's possible to provide additional context fields by subclassing AdminSite and overriding each_context(). Does this make this ticket unnecessary? I'll happily fix up the patch if it's useful, but I don't want to do that if the feature is no longer needed.

[Berker Peksag]

​https://github.com/django/django/pull/3644

[Tim Graham <timograham@…>]

In c8dcded930a1d0ee5688ae2c2eeb8c33d942009f:

Fixed #17890 -- Added an extra_context parameter to AdminSite.password_change().