Opened 13 years ago
Closed 13 years ago
#17879 closed Bug (fixed)
Regression in serializers when using natural keys
| Reported by: | Dan Fairs | Owned by: | Karen Tracey |
|---|---|---|---|
| Component: | Core (Serialization) | Version: | |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The Python serializer's handle_fk_field() method now no longer handles the case where a related object is None and natural keys are in use. The problem appears to have been introduced in this changeset:
The code now no longer checks to see if the related object is not None before attempting to call natural_key() on it.
Attachments (1)
Change History (8)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Severity: | Normal → Release blocker |
|---|
comment:3 by , 13 years ago
Not yet - I'll try to put one together as soon as I can (realistically, over the next day or so.)
comment:5 by , 13 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Bug |
D'oh referenced the wrong ticket in the patch, but the patch is for this ticket.
comment:6 by , 13 years ago
| Owner: | changed from to |
|---|
Note:
See TracTickets
for help on using tickets.
Upon inspection this appears to be a regression therefore marking as release blocker. I don't supposed you have a test?