Opened 13 years ago
Closed 12 years ago
#17818 closed New feature (duplicate)
Generic edit generic views don't create `fail_silently` success messages anymore.
| Reported by: | Simon Charette | Owned by: | Simon Charette |
|---|---|---|---|
| Component: | Generic views | Version: | dev |
| Severity: | Normal | Keywords: | views generic edit messages |
| Cc: | marc.tamlyn@…, hirokiky@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
It looks like the creation of success messages on valid form submission was oversight when the generic class based views were designed.
Here's a link to the django-developper discussion that motivated the creation of this ticket.
I'm also attaching a patch (with no tests and docs) that provide a simple yet overridable implementation that mimic the deprecated function based behaviour.
Attachments (2)
Change History (6)
by , 13 years ago
| Attachment: | class-based-generic-edit-views-messages-v1.diff added |
|---|
comment:1 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | Uncategorized → New feature |
comment:2 by , 12 years ago
| Cc: | added |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
| Version: | 1.3 → master |
comment:4 by , 12 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Closing as duplicate of #16319.
Note:
See TracTickets
for help on using tickets.
I'm +1 on this feature being reintroduced, but -1 on it being on by default, especially as this would constitute a backwards incompatibility to me. We have views around which create messages similar to this, and turning it back on by default would mean duplicate messages, or messages where none were expected.
That said it's probably a useful feature by default, but I think there should be an upgrade path.