extends template tag mishandles filter expressions

[FunkyBob]

For unknown reasons, the {% extends %} tag tries to manually identify string literals as the argument, by testing if they start and end with the same char, and that char is ' or "

This test fails with the following trivial case:

{% extends "something"|afilter:"else" %}

I can see little to no reason not to switch to using the same argument filtering as everyone else, except for the _tiny_ amount of extra debug information provided.

[FunkyBob]

Fair's fair... it was bradleyayers who brought this bug to my attention... I just formulated the patch.

[Chris Beaven]

Needs a test and a quick note in the changes docs that the ExtendsNode definition changed (even though it's not documented, it's still a nice thing to mention)

[Chris Beaven]

You could easily keep the "tiny bit of debugging" with this:

if self.parent_name.filters or isinstance(self.parent_name.var, Variable):

[FunkyBob]

After further discussion with SmileyChris, here is a patch which doesn't lose the extra debugging info, instead showing the actual expression used.

[Bradley Ayers <bradley.ayers@…>]

test

[FunkyBob]

Release notes doc patch

[Chris Beaven]

The notes should mention the change in arguments to the ExtendsNode for anyone who may have been extending/using it in their tag.

[FunkyBob]

Updated docs patch

[Chris Beaven]

In [17568]:

Fixed #17660 -- Standardize extends tag token parsing