Opened 13 years ago

Closed 13 years ago

#17458 closed Bug (fixed)

Http404 untranslatable strings

Reported by: Claude Paroz Owned by: nobody
Component: Internationalization Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Several Http404 errors throughout django codebase are not set as translatable. For contrib apps that are not yet translatable, I don't think it's worth triggering the translation machinery, but for those who already have a locale dir, I'll prepare a patch.

Attachments (1)

17458-1.diff (6.1 KB ) - added by Claude Paroz 13 years ago.
Set Http404 strings as translatable

Download all attachments as: .zip

Change History (7)

by Claude Paroz, 13 years ago

Attachment: 17458-1.diff added

Set Http404 strings as translatable

comment:1 by Claude Paroz, 13 years ago

Has patch: set

comment:2 by Aymeric Augustin, 13 years ago

Triage Stage: UnreviewedAccepted

comment:3 by Karen Tracey, 13 years ago

Note Http404 strings are debug information -- these are only shown to users when DEBUG is True. We don't generally translate development/debug strings, do we?

comment:4 by Claude Paroz, 13 years ago

Karen, you are right in that currently these messages are not shown to the user when DEBUG is False. But I think it's still valuable to have them translated (it's already the case for other 404 errors in Django code). I even think that we might one day pass this information to the handlerxxx callbacks, so that custom 404 templates may choose to display more detailed output, if desired (an idea for a new ticket!).

comment:5 by Jannis Leidel, 13 years ago

Yeah, I agree we need to be consistent with regard to translating the 404 debug information, and I'd prefer having translated error messages if possible.

comment:6 by Jannis Leidel, 13 years ago

Resolution: fixed
Status: newclosed

In [17447]:

Fixed #17458 -- Marked Http404 error messages for translation. Thanks, Claude Paroz.

Note: See TracTickets for help on using tickets.
Back to Top