Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#17183 closed Cleanup/optimization (fixed)

i18n documentation: middleware not mentioned until very late

Reported by: anonymous Owned by: Christopher Medrela
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: krzysiumed@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the documentation for i18n/l10n there is no mention of adding the 'django.middleware.locale.LocaleMiddleware' to the MIDDLEWARE_CLASSES setting until the third (and last) step of the documentation (​https://docs.djangoproject.com/en/dev/topics/i18n/deployment/).

This is a little confusing for developers like me who like to jump right into things as soon as they have read the first part of the documentation (I do realize this may not be the best approach but believe me, I'm not the only one who does this). I think adding a small paragraph at the beginning of the i18n documentation (​https://docs.djangoproject.com/en/dev/topics/i18n/translation/) about what is needed to get everything working would be beneficial.

Attachments (1)

17183.diff​ (749 bytes ) - added by Christopher Medrela 13 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by stefan.freyr@…, 13 years ago

comment:2 by stefan.freyr@…, 13 years ago

Component: Uncategorized → Documentation
Type: Uncategorized → Cleanup/optimization

comment:3 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

This problem is a consequence of the recent refactoring of the i18n docs.

by Christopher Medrela, 13 years ago

Attachment: 17183.diff​ added

comment:4 by Christopher Medrela, 13 years ago

Has patch: set
Owner: changed from nobody to Christopher Medrela
Status: new → assigned

Note that first link in description of the ticket is broken. The correct one is ​https://docs.djangoproject.com/en/1.3/topics/i18n/deployment/ for 1.3 and ​https://docs.djangoproject.com/en/dev/topics/i18n/translation/#how-django-discovers-language-preference for dev version.

comment:5 by Christopher Medrela, 13 years ago

Cc: krzysiumed@… added

comment:6 by Tim Graham <timograham@…>, 12 years ago

Resolution: → fixed
Status: assigned → closed

In [b1f18e95a5481e582f52a42807506369b73d8c6a]:

Fixed #17183 - Added a note regarding LocaleMiddleware at the top of the i18n docs. Thanks krzysiumed for the patch.

comment:7 by Tim Graham <timograham@…>, 12 years ago

In [e4b7e7d86deb1303997d6c3b893c76ead2d6d46a]:

[1.4.X] Fixed #17183 - Added a note regarding LocaleMiddleware at the top of the i18n docs. Thanks krzysiumed for the patch.

Backport of b1f18e95a5 from master

Note: See TracTickets for help on using tickets.
Back to Top