Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#17094 closed Bug (fixed)

DeletionMixin get_success_url parameter

Reported by: Alejandro Varas Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In ​https://docs.djangoproject.com/en/1.3/ref/class-based-views/#django.views.generic.edit.DeletionMixin.get_success_url says that get_success_url get a parameter(obj) but this doesn't happen on the source code.

Change History (5)

comment:1 by Julien Phalip, 13 years ago

Triage Stage: Unreviewed → Ready for checkin
Type: Uncategorized → Bug

Thanks, good catch. obj just needs to be removed from the doc (​https://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.edit.DeletionMixin.get_success_url).

comment:2 by Julien Phalip, 13 years ago

Triage Stage: Ready for checkin → Design decision needed

Sorry, I've been a bit too quick in my initial judgment. A case could be made that it's the code that needs changing. Indeed, the delete() method could technically pass the deleted object to the get_success_url() method as is currently documented. Marking as DDN as I'm personally not feeling strong about either way.

comment:3 by Tim Graham, 12 years ago

Doesn't seem needed since you can access the object using self.object.

comment:4 by Tim Graham <timograham@…>, 12 years ago

Resolution: → fixed
Status: new → closed

In c89717fabee46d70d73308f8ba1f2510f07bd596:

Fixed #17094 - Typo in class-based views doc.

Thanks alej0 for the report.

comment:5 by Tim Graham <timograham@…>, 12 years ago

In e69d810741b145100b9f0c9a4ce165adb9e2775f:

[1.5.x] Fixed #17094 - Typo in class-based views doc.

Thanks alej0 for the report.

Backport of c89717fabe from master.

Note: See TracTickets for help on using tickets.
Back to Top