RegexValidator.message is not used

[jbcurtincode@…]

Error_messages works correctly, however with and with out error_messages, RegexValidator.message never pops up.

class UserIdForm(forms.Form):
    user_id = forms.CharField( max_length=50,
        label = _("Id"),
        help_text = _("Enter your ID."),
        error_messages = {
            'invalid':_(u"Your ID may only contain letters and numbers."),
            'required':_(u"Enter your ID."),
        },
        validators=[
            RegexValidator( 
                            regex='^[a-zA-Z0-9]*$',
                            message=_(u"Forgotten message."),
                            )
            ]
    )

{% for field in form %}
    {{field}}{{field.help_text}}
    <br/>
    {% for error in field.errors %}
        {{error}}
    {% endfor %}
{% endfor %}

[Claude Paroz]

There is an obvious conflict between the 'invalid' error message from the field and the validator (which default to the 'invalid' key also). If you specify an 'invalid' error message at field level, it will overwrite the 'invalid' error message from the Validator, by current design. In my opinion, it's not a bug.

[anonymous]

Replying to claudep:

There is an obvious conflict between the 'invalid' error message from the field and the validator (which default to the 'invalid' key also). If you specify an 'invalid' error message at field level, it will overwrite the 'invalid' error message from the Validator, by current design. In my opinion, it's not a bug.

You're absolutely right, but in the absence of the 'invaild' error message the bug persists. The message property is never used.
​https://docs.djangoproject.com/en/dev/ref/validators/#regexvalidator

I will update the ticket to convey this more accurately.

[anonymous]

Replying to anonymous:

Replying to claudep:

There is an obvious conflict between the 'invalid' error message from the field and the validator (which default to the 'invalid' key also). If you specify an 'invalid' error message at field level, it will overwrite the 'invalid' error message from the Validator, by current design. In my opinion, it's not a bug.

You're absolutely right, but in the absence of the 'invaild' error message the bug persists. The message property is never used.
​https://docs.djangoproject.com/en/dev/ref/validators/#regexvalidator

I will update the ticket to convey this more accurately.

Well, I can't seem to edit the ticket since I forgot to login when I made it.

To recreate the bug with the code above, comment out the invalid error_message.

[Claude Paroz]

Well, I investigate this issue a little more. The point is about what between field 'invalid' message and validator 'invalid' error message will take precedence. As you pointed out, the field message is currently always winning. Now if you want the validator message to win, you have to provide another error code, like 'invalid_regex':

RegexValidator( 
    regex='^[a-zA-Z0-9]*$',
    message=_(u"Forgotten message."),
    code='invalid_regex',
)

I tried to see if the code could be changed so as to choose the more specific message. But it is not possible to determine which is the most specific. Sometimes the validator error message is more specific, sometimes the field one is. That's why I think you should use the code trick above.

[Claude Paroz]

Unset 'invalid' error_message on base Field class

[Claude Paroz]

Eventually I still found that the 'invalid' key of the base Field class was masking some useful validator messages. So I'm suggesting the above patch to improve this issue. The trick I described in comment:6 is still useful in case of specific Fields which define a default_error_messages['invalid'] entry.

[Claude Paroz]

#17679 is a duplicate with a link to a Github branch for a fix (​https://github.com/insin/django/compare/validators-error-messages).

[Claude Paroz <claude@…>]

In 2f121dfe635b3f497fe1fe03bc8eb97cdf5083b3:

Fixed #17051 -- Removed some 'invalid' field error messages

When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.