#16980 closed Cleanup/optimization (fixed)
updates and fixes to auth docs
| Reported by: | Preston Holmes | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Attachments (1)
Change History (5)
by , 13 years ago
| Attachment: | auth_docs_cleanup.diff added |
|---|
comment:1 by , 13 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 13 years ago
switching to pull request, this supersedes the attached diff:
https://github.com/django/django/pull/59
I added the note about rate limiting as suggested.
One potential cleanup would be to also combine the sections on handling anonymous and inactive users, though that could wait until 1.5 and the deprecation conclusion.
Also per this discussion http://groups.google.com/group/django-developers/browse_thread/thread/bad403fd55a0b1d6
I may add on a note about the current behavior of login_required to this cleanup
comment:3 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
This looks excellent, thanks! I've just got a couple of minor remarks: The reference "inactive_auth" is probably not necessary since it doesn't seem to be used; and I think it'd be useful to add, as pointed by PaulM in #15600, something along the lines of "You may either implement your own rate limiting mechanism or use the mechanisms provided by most Web servers (such as NginX or Apache)".