Opened 13 years ago

Closed 13 years ago

#16967 closed Bug (fixed)

CachedStaticFilesStorage only populates the file name cache once, never updates

Reported by: mkai Owned by: nobody
Component: contrib.staticfiles Version: dev
Severity: Normal Keywords: CachedStaticFilesStorage, cache
Cc: Jannis Leidel Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I noticed that the cache that CachedStaticFilesStorage uses for performance reasons (i. e. to avoid having to recalculate the MD5 hash for a file's contents) is populated only once, during collectstatic. Therefore, if memcached goes down and needs to be restarted, it will need to recalculate the MD5 hash for every subsequent static file request, because the cache query will always miss.

I suggest that if a cache query misses, the corresponding file name in the cache should be updated/ rewritten.

Change History (3)

comment:1 by Aymeric Augustin, 13 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Jannis Leidel, 13 years ago

Sounds like a plan, indeed.

comment:3 by Jannis Leidel, 13 years ago

Resolution: → fixed
Status: new → closed

In [17067]:

Fixed #16967 -- Made sure CachedStaticFilesStorage repopulates its cache if there was a miss (for example if the cache server went down).

Note: See TracTickets for help on using tickets.
Back to Top