disconnect signal before checking test success

[adsworth]

Disconnect the presave signal before calling assertEquals, in the test regressiontests.fixtures_regress.tests.TestFixtures.test_field_value_coerce
. If the test fails (as it currently does for Python 3) the pre_save signal stays connected and causes a multitude of later tests to error.

before fix:
Ran 4036 tests in 94.677s

FAILED (failures=505, errors=1375, skipped=56, expected failures=1, unexpected successes=1)

after fix:
Ran 4090 tests in 229.091s

FAILED (failures=600, errors=770, skipped=72, expected failures=2, unexpected successes=1)

[Aymeric Augustin]

The best best way to ensure the signal gets disconnected is to use a try / finally. See attached patch.

I'm not sure how to run the tests under Python 3 — I checked out the py3k branch, but runtests.py fails with this error:

  File "runtests.py", line 118
    print "Importing application %s" % module_name
                                   ^
SyntaxError: invalid syntax

If the new patch works for you, feel free to mark the ticket as RFC.

[adsworth]

The patch from aaugustin works fine in Python3.

To run the test in Python 3 you need at least 3.2 and then run the py3ktest script in the py3k branch.

[Alex Gaynor]

In [16905]:

Fixed #16925 -- Make sure a signal is disconnected if the test fails. Thanks to aaugustin for the patch.