Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#16789 closed Cleanup/optimization (fixed)

use named urls in django.contrib.auth.urls

Reported by: wim@… Owned by: Flavio Curella
Component: contrib.auth Version: 1.3
Severity: Normal Keywords:
Cc: chris@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Use named urls in django.contrib.auth: eat own dogfood and make it possible to use reverse auth urls for everyone! Freedom to the people!

Attachments (3)

named_auth_urls_ticket16789.diff​ (2.0 KB ) - added by wim@… 13 years ago.
add names to auth/urls.py
t16789-with-docs.diff​ (5.1 KB ) - added by Chris Heisel 13 years ago.
Named URL patterns plus docs
t16789-with-docs-and-tests.diff​ (7.3 KB ) - added by Chris Heisel 13 years ago.
Docs and tests

Download all attachments as: .zip

Change History (19)

by wim@…, 13 years ago

Attachment: named_auth_urls_ticket16789.diff​ added

add names to auth/urls.py

comment:1 by Flavio Curella, 13 years ago

Component: Uncategorized → contrib.auth

comment:2 by Flavio Curella, 13 years ago

Has patch: set
Needs documentation: set

I think we should document the view names somewhere in the docs.

comment:3 by Chris Heisel, 13 years ago

Owner: changed from nobody to Chris Heisel
Status: new → assigned

comment:4 by Chris Heisel, 13 years ago

Needs documentation: unset
Owner: changed from Chris Heisel to Flavio Curella
Status: assigned → new
Triage Stage: Unreviewed → Accepted

Updated patch with documentation. Sending to fcurella for review.

comment:5 by wim@…, 13 years ago

Hi cmheisel,

It seems the diff contains more than one fix. Could you please look into this?

Thanks!

Wim

by Chris Heisel, 13 years ago

Attachment: t16789-with-docs.diff​ added

Named URL patterns plus docs

comment:6 by Chris Heisel, 13 years ago

Wim / fcurella -- sorry about that! Fixed the patch.

comment:7 by Chris Heisel, 13 years ago

Cc: chris@… added

comment:8 by Flavio Curella, 13 years ago

Triage Stage: Accepted → Ready for checkin

comment:9 by Flavio Curella, 13 years ago

Needs tests: set
Triage Stage: Ready for checkin → Accepted

Not sure if tests for this patch would be overkill.

Last edited 13 years ago by Flavio Curella (previous) (diff)

comment:10 by wim@…, 13 years ago

We could just do a reverse lookup for the url names?

by Chris Heisel, 13 years ago

Attachment: t16789-with-docs-and-tests.diff​ added

Docs and tests

comment:11 by Chris Heisel, 13 years ago

Needs tests: unset

Added a new patch that includes tests as well

comment:12 by wim@…, 13 years ago

Hi cmheisel,

Thanks for the patch! I want to run it and the tests to mark it as Ready for Checkin, however, unfortunately, I am unable to apply your patch, because it is not a svn diff. Could you make it into a svn diff?

As far as I know, patches are supplied here as svn diffs at the ticket. Or did I miss something and did this policy change?

Wim

comment:13 by Chris Heisel, 13 years ago

Wim,

Sure thing, I didn't realize they weren't compatible.

I'll generate a plain-ole-diff and resubmit.

Chris

comment:15 by Wim Feijen <wim@…>, 13 years ago

Triage Stage: Accepted → Ready for checkin

Thanks Alex.

Patch and docs are complete, so: ready for check-in.

comment:16 by Ramiro Morales, 13 years ago

Resolution: → fixed
Status: new → closed

In [16901]:

Fixed #16789 -- Added names to URLs in convenience contrib.auth urls.py.

Thanks wim AT go2people DOT nl for the report, cmheisel for the patch and
fcurella for reviewing it.

Note: See TracTickets for help on using tickets.
Back to Top