{% load %} doesn't work with libraries in package heierarcy

[Ivan Sagalaev]

In other words {% load package.lib %} doesn't work.

The docstring of load tag suggests it should work and it used to work before changeset r12944. We should allow this behavior again and document it properly in docs.

[Jannis Leidel]

This is a regression and therefore a release blocker.

[Ivan Sagalaev]

Patch with tests and docs

[Ivan Sagalaev]

Patch with all new included.

[Ivan Sagalaev]

More specific tests

[Ivan Sagalaev]

Fixed some typos, reformulated docstring.

[Chris Heisel]

I'm getting a test failure:

python runtests.py --settings=test_sqlite templates

TemplateSyntaxError: 'subpackage.echo' is not a valid tag library: Template library subpackage.echo not found, tried django.templatetags.subpackage.echo,django.contrib.flatpages.templatetags.subpackage.echo,django.contrib.comments.templatetags.subpackage.echo,django.contrib.admin.templatetags.subpackage.echo,django.contrib.staticfiles.templatetags.subpackage.echo,django.contrib.humanize.templatetags.subpackage.echo,regressiontests.templates.templatetags.subpackage.echo

[Tobias McNulty]

The patch includes an empty __init__.py file which didn't get added for me when I applied it. Running this fixes it:

touch tests/regressiontests/templates/templatetags/subpackage/__init__.py

I reviewed the patch with Ivan at the sprint today and I'm happy with v4. As he said in the description, this functionality used to exist, so we don't think there's a need for a separate section in the docs explaining it.

[Ivan Sagalaev]

BTW does anyone if it's possible to include an empty file in a diff?

[Aymeric Augustin]

I did a lot of research on this problem recently and the best solution I've found is to generate the diff with git — but that only works if you apply it with "git apply".

[Ivan Sagalaev]

This won't work for me since I use bzr :-). This is the one place where standardizing on svn and patch utility sucks…

[Ivan Sagalaev]

Patch updated to current trunk

[Aymeric Augustin]

In [17133]:

Fixed #16787 -- Restored the ability to {% load %} template tags libraries within packages. Thanks Ivan Sagalaev for the report and patch.