Model field clash not detected beyond parent

[Leo Shklovskii]

When a local field in a class has the same name as a field in the superclass Django throws a FieldError when it spins up. However, it only checks the immediate parent, it doesn't go further up the tree so the following code doesn't trigger a FieldError (which it should):

class A(models.Model):
    foo = models.IntegerField()

class B(A):
    pass

class C(B):
    foo = models.IntegerField()

[Aymeric Augustin]

I confirm the bug. With this code in a models.py:

class GrandParent(models.Model):
    number = models.IntegerField()

class Parent(GrandParent):
    pass

class Child(Parent):
    number = models.IntegerField()

Expected result of ./manage.py validate:

FieldError: Local field 'number' in class 'Child' clashes with field of similar name from base class 'GrandParent'

Actual result: no error.

I tried to write a test case in invalid_models, but that didn't work because the name clash creates an exception, not a validation error.

[Tim Graham]

Confirmed this is still an issue with the attached test for Django's test suite.

[Karl]

I think this ticket can be marked as fixed or duplicate now, fixed here #24249.

[Claude Paroz]

Right, thanks for checking (Tim's test is now passing well).

[Leo Shklovskii]

Thanks guys! Great to have this cleaned up!