ssi template tag fails when the path to the template contains a space

[Aymeric Augustin]

I initially noticed this problem here: ​http://ci.myks.org/job/Django%20+%20Oracle/42/console

Since the project is called "Django + Oracle", the checkout ends up in "/var/lib/jenkins/jobs/Django + Oracle/workspace", and there are spaces in the paths to the templates used by the tests.

To reproduce the problem, move your checkout of django so there's a space somewhere in the path (for instance mv django-trunk "django trunk") and run PYTHONPATH=.. ./runtests.py --settings=test_sqlite templates.

Apparently the current implementation of the ssi tag doesn't support spaces in the path to the template.

[Aymeric Augustin]

The ssi tag is defined twice, in django/template/defaulttags.py and in django/templatetags/future.py. I recommend:

• not changing the behavior of the "old" version, and just disable its tests when the path contains a space; all this code will be removed in Django 1.5 anyway.
• fixing the "new" version by using token.split_contents() (quotes-aware spitting) instead of token.contents.split() (naïve splitting) to parse the content of the tag.

I think the second point is a real bug and I've added a test case for it — a template whose file name contains spaces.

Attached patch implements this.

[Julien Phalip]

Thanks for the report and fix! The patch looks good. However, why only fix the future version? I don't see why both versions shouldn't be fixed in 1.4.

[Aymeric Augustin]

Changes in the 2nd iteration of the patch:

• two tests were added to check that it's still a TemplateSyntaxError to use spaces in the path to the template with the "old" ssi tag.
• the tests of the "old" ssi tag are now changed to expect TemplateSyntaxError when the path to the Django checkout contains spaces, instead of just being removed.

[Julien Phalip]

Perfect, thank you!

[Julien Phalip]

In [16687]:

Fixed #16677 -- Fixed the future version of the ssi template tag to work with template file names that contain spaces. Note that this fix cannot be applied to the currently deprecated version of the ssi tag since it requires an unquoted literal as parameter. Many thanks to Aymeric Augustin for the report and patch.

[Aymeric Augustin]

In [17804]:

[1.3.X] Fixed #16677 -- Fixed the future version of the ssi template tag to work with template file names that contain spaces. Backport of r16687 from trunk.