Opened 13 years ago

Closed 13 years ago

#16661 closed Cleanup/optimization (fixed)

Improvement of readability - false negation?

Reported by: greggmasterflash@… Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

It doesn't matter which model gets the ManyToManyField, but you only need it in one of the models -- not in both.
->
It doesn't matter which model gets the ManyToManyField, and you only need it in one of the models -- not in both.

Attachments (1)

16661.patch​ (787 bytes ) - added by Aymeric Augustin 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:2 by Aymeric Augustin, 13 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted

Yes, the wording here could be improved. Trivial patch attached.

by Aymeric Augustin, 13 years ago

Attachment: 16661.patch​ added

comment:3 by Julien Phalip, 13 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Malcolm Tredinnick, 13 years ago

The proposed change doesn't improve the clarity, since it's important the field is only put on one of the models. The suggested new text makes it sound like it might be okay to have it on both. I am committing a small variation that makes this clear (strengthening the negative, in fact).

comment:5 by Malcolm Tredinnick, 13 years ago

Fixed in r16639.

comment:6 by Malcolm Tredinnick, 13 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.
Back to Top