DiscoverRunner API makes re-use difficult.

[Tom Christie]

Would be better if it allowed the test suite class and test runner class to be overridden.

[Tom Christie]

NB: Note the same pattern in unittest2 - ​http://hg.python.org/unittest2/file/d2be68aedc8e/unittest2/runner.py#l129

[Jannis Leidel]

Sounds like a reasonable idea.

[Tom Christie]

Being able to override the test loader too would be even better...

[Tom Christie]

Also allow test_runner to be overridden

[Andy Baker <andy@…>]

Don't think this needs documentation - it's an internal interface, and don't think it needs tests as it's clean-up, not new functionality.

[Tom Christie]

Hadn't noticed those were still set. Thanks.

[Ramiro Morales]

DjangotestSuiteRunner is documented, changes introduced for this ticket also need documentation.

[Tom Christie]

Replying to ramiro:

DjangotestSuiteRunner is documented, changes introduced for this ticket also need documentation.

Ah, true. I'll get that sorted, then...

[Tom Christie]

Don't know how this patch applies given 1.6's incoming test runner changes, if anyone's picking this up at DjangoCon, that'd need investigation first...

[Cliff Dyer]

I'm taking a look at this....

[Cliff Dyer]

So it doesn't apply as is. I've modified to to work with the new subclassing of DiscoverRunner. All tests still pass. I'm looking into the documentation situation, and then I'll be uploading a patch.

[Cliff Dyer]

New patch that works with DiscoverRunner instead of DjangoTestSuiteRunner

[Cliff Dyer]

Looking more closely, DjangoTestSuiteRunner is deprecated. Updating it seems like the wrong way to move forward. Instead, we should ensure that the new hotness (DiscoverRunner) contains the requested features.

It already allows overriding test_loader. Following the example in previous patches, I have updated DiscoverRunner to allow overriding the test suite and the unittest-level test runner (TextTestRunner). I have also updated the documentation of DiscoverRunner at topics/testing/advanced/ to detail these attributes.

In a small departure from earlier patches, I have taken the liberty of renaming suite_class to test_suite (for consistency with test_runner and test_loader). Because it is pending deprecation, no enhancements have been made to django.test.simple or the DjangoTestSuiteRunner.

[Cliff Dyer]

Added documentation updates suggested on IRC by timograham

[Cliff Dyer]

Changed the ticket title to reflect the new direction of the ticket.

[Cliff Dyer]

Added documentation updates suggested on IRC by timograham (edited to fix a documentation typo: DicsoverRunner)

[Cliff Dyer]

One last attachment, this one with tests.

[Cliff Dyer]

I added tests. They're pretty brain dead, because the entire change was an attribute creation refactor, but now that the attributes are documented, we want to be notified if they go away or become the wrong thing.

[Cliff Dyer]

Created a ticket to track backporting some documentation changes to 1.6.

[Tim Graham <timograham@…>]

In 4ba373840a7b299fff4a7bcc1001e32dffceee86:

Fixed #16534 -- Improved ability to customize DiscoverRunner

Added DiscoverRunner.test_suite and .test_runner attributes.

Thanks tomchristie for the suggestion and jcd for the patch.