Opened 13 years ago
Closed 13 years ago
#16272 closed Cleanup/optimization (fixed)
Date-related widgets still have format attribute set on class
| Reported by: | Bas Peschier | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Normal | Keywords: | widgets |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
For example: https://code.djangoproject.com/browser/django/trunk/django/forms/widgets.py?rev=16363#L374
These definitions on the class seem to be superseded by settings-based formats (formats.get_format), they can probably be removed.
Attachments (1)
Change History (5)
by , 13 years ago
| Attachment: | 16272.patch added |
|---|
comment:1 by , 13 years ago
| Has patch: | set |
|---|---|
| Needs documentation: | set |
| Patch needs improvement: | set |
comment:2 by , 13 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 13 years ago
| Patch needs improvement: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Patch does not break anything here as well.
Documentation issue is handled by #16264, which has a patch.
Note:
See TracTickets
for help on using tickets.
The patch I just attached doesn't break anything in the test suite.
The documentation in
docs/ref/forms/widgets.txtshould be updated to reflect the fact that the default value is now taken from the formats for the current locale whenUSE_L10NisTrue.