Opened 13 years ago
Closed 13 years ago
#16219 closed New feature (wontfix)
Added favicon for admin
Reported by: | niels_bom | Owned by: | niels_bom |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description
Added a favicon in .png format for the admin. I used the colorscheme of admin.
Attachments (2)
Change History (10)
by , 13 years ago
Attachment: | 16219.patch added |
---|
by , 13 years ago
Attachment: | favicon.png added |
---|
comment:1 by , 13 years ago
comment:2 by , 13 years ago
Could you add a block around it? So it could be changed without too much hassle
comment:3 by , 13 years ago
I agree on the rounded corners and the block.
Works on FF 3.6.17 on Ubuntu
comment:4 by , 13 years ago
I will also do the following check (thanks for the idea to Klaas van Schelven):
www.example.com has favicon A
www.example.com/admin has favicon B
Then check that www.example.com won't ever show favicon B.
Will check this in IE7+, FF3+, Chrome, Safari
comment:5 by , 13 years ago
Do we want a Django favicon for the admin? I would have thought the admin should get the same favicon as the rest of the site. It is, after all, just one contrib app. No other contrib app or 3rd party Django app would get Django branding.
comment:6 by , 13 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
I agree with lukeplant - this seems odd and unnecessary.
comment:7 by , 13 years ago
True, but most apps don't provide templates and css either. The admin does so why not add a favicon
comment:8 by , 13 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
I've thought about this more, and I don't think its appropriate.
Unlike CSS and styling, favicons are all about site identity. Adding a favicon for the admin would be asserting brand identity of one of the tools used to make the website, or one section of the website, which doesn't seem appropriate for any web development tool. I wouldn't expect a component provided by any other web framework to do this. I don't even like it when an out-of-the-box solution like WordPress provides its own favicon (I don't know if they do any more). When you see those default favicons on websites, they look unprofessional - I only expect to see the WordPress favicon if I'm on wordpress.com.
I don't know what other core devs think, none has contributed so far. I'm going to close as wontfix, but please bring it up on django-devs if you'd like other opinions.
Just tried it out, works nicely with FF 4.0.1 and Safari (both on Mac).
The design of the icon could be a little bit more near the favicon of djangoproject.com, at least the rounded corners