Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#15490 closed (fixed)

Some semicolons are missing in javascript code.

Reported by: jonathanslenders Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Several semicolons are missing in javascript code. (Statements need to be terminated by semicolons, even if browsers do not always require it.)

Attachments (1)

patch2.patch​ (1.7 KB ) - added by jonathanslenders 14 years ago.

Download all attachments as: .zip

Change History (7)

by jonathanslenders, 14 years ago

Attachment: patch2.patch​ added

comment:1 by Russell Keith-Magee, 14 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Russell Keith-Magee, 14 years ago

Thanks for the patch Jonathanl; for future reference, please generate diffs against the root of the source tree, so we don't have to go hunting to work out where the patch applies cleanly.

comment:3 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

In [15641]:

(The changeset message doesn't reference this ticket)

comment:4 by Russell Keith-Magee, 14 years ago

In [15643]:

[1.2.X] Fixed #15490 -- Added some missing semicolons in admin javascript. Thanks to Jonathan Slenders for the report and patch.

Backport of r15641 from trunk.

in reply to:  2 comment:5 by jonathanslenders, 14 years ago

Replying to russellm:

Thanks for the patch Jonathanl; for future reference, please generate diffs against the root of the source tree, so we don't have to go hunting to work out where the patch applies cleanly.

Thanks for the tip, I'll do that next time.

comment:6 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top