UpdateView raises exception about overiding get_object

[sergeybe@…]

I've defined the view class:

class OneAuthorUpdate(generic.UpdateView):

    def get_object(self):
        return Author.objects.get(pk=1)

But next exception raises:

ImproperlyConfigured: OneAuthorUpdate is missing a queryset. Define OneAuthorUpdate.model, OneAuthorUpdate.queryset, or override OneAuthorUpdate.get_object()

[Sergey N. Belinsky <sergeybe@…>]

Tests for UpdateView and get_object method

[Russell Keith-Magee]

Confirmed that the test case fails as described; need to dig in closer to see exactly why. Marking as a blocker for the moment, because at the very least, it's confusing.

[Russell Keith-Magee]

I've found the cause -- you've overridden get_object, but you haven't provided a form, so the call to get_form_class() is calling get_queryset() as a cheats way to find the model that can be used to automatically construct a ModelForm.

The simple workaround -- specify a form_class. I'm looking into what we can do as a permanent solution.

[Russell Keith-Magee]

In [15540]:

Fixed #15247 -- Ensured that if a SingleObject? view defines get_object but not get_queryset, the ModelFormMixin? doesn't fail. Thanks to Sergey N. Belinsky for the report and test case.

(Fat fingers attributed this to the wrong ticket)

[Sergey N. Belinsky <sergeybe@…>]

It works now. Thank you!

[Jacob]

Milestone 1.3 deleted