"Save as" does not save entries added with a Inline

[rax]

What steps will reproduce the problem?

1. go to the admin change form of an instance of a model class with both the "save as" feature enabled, and a TabularInline for relate items.
2. change the original instance
3. add a new related instance using the TabularInline

What is the expected output? What do you see instead?

A new instance should be created, a copy of all the related instances should be created and a new instance for any item added in the TabularInline should be created.
Instead the original item is created, all the pre-existing instances are copied but the new ones are not created.

Note: deleting an entry works as expected is just the add that "fails" by creating the new instance without adding the new related items.

Additional information

django version: 1.2.3
locale: it-IT

this may also be related to #4045

[rax]

Patch fixing the issue

[rax]

The "save as" button in the admin change form simply redirects to the add_view with the only difference that the "save_as_new" parameter is passed to the formset:

formset = FormSet(data=request.POST, files=request.FILES,
         instance=new_object,
         save_as_new=request.POST.has_key("_saveasnew"),
         prefix=prefix, queryset=inline.queryset(request))

Where "FormSet" are instances of "BaseInlineFormSet"

It's a problem in the BaseInlineFormSet class. See the attached patch.

[Julien Phalip]

Yes, I could verify this issue. Here's a simple test case:

Models:

from django.db import models

class Foo(models.Model):
    name = models.CharField(max_length=30)

class Bar(models.Model):
    parent = models.ForeignKey(Foo)
    title = models.CharField(max_length=30)

Admin:

from django.contrib import admin
from .models import Foo, Bar

class BarInline(admin.StackedInline):
    model = Bar

class FooAdmin(admin.ModelAdmin):
    inlines = (BarInline,)
    save_as = True

admin.site.register(Foo, FooAdmin)

New inlines added before clicking "Save as new" get lost.

I really doubt your patch is the way to go , though.

[Julien Phalip]

#14949 was closed as dupe.

[Ramiro Morales]

(reformatted description)

[Ramiro Morales]

Actually, the modification proposed by the OP doesn't seem wrong. Simply removing the BaseInlineFormSet implementation of the total_form_count() method and so leaving to defer to the implementation in BaseFormSet makes the newly filled inline formsets to get validated and (once corrected if they didn't validate) saved associated with the new cloned parent model instance

That if self.save_as_new : condition was added when these methods (total_form_count() and initial_form_count()) were introduced back in r10190 ~two years ago.

Joseph Kocherhans expressed on IRC it is possible this might be an implementation bug.

Changing component because this doesn't seem to be a admin-specific problem.

[Russell Keith-Magee]

Not sure why I marked this blocker, regression; on inspection, it doesn't appear to be either. It's been a problem since at least 1.1.X, and it doesn't involve data loss (there's lost data on entry, but nothing destructive happens to existing data)

[Carl Meyer]

(In [15306]) Fixed #14938 - Fixed save-as-new on inline formset with new forms.

[Carl Meyer]

(In [15307]) [1.2.X] Fixed #14938 - Fixed save-as-new on inline formset with new forms.

Backport of r15306 from trunk.

[Jacob]

Milestone 1.3 deleted