Opened 14 years ago

Closed 14 years ago

Last modified 11 years ago

#14868 closed (fixed)

admin: prevent long text from overflowing recent actions box

Reported by: Chris Adams Owned by: Chris Adams
Component: contrib.admin Version: 1.2
Severity: Keywords: css, easy-pickings
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The recent actions text will overflow the container when the recent action contains something which cannot be word-wrapped normally, such as a filename, large number, etc.

The patch at ​https://github.com/acdha/django/compare/1.2.3...admin-recent-actions-text-overflow avoids this problem by setting the CSS text-overflow property, allowing normal word wrapping but causing the
browser to truncate text with an ellipsis when necessary

Attachments (3)

Screen shot 2010-12-08 at 11.19.18 AM.png​ (10.9 KB ) - added by Chris Adams 14 years ago.
Example of overflow (IE8)
Screen shot 2010-12-08 at 11.33.59 AM.png​ (9.9 KB ) - added by Chris Adams 14 years ago.
Example with the change (IE8)
admin-recent-actions-text-overflow.patch​ (1.1 KB ) - added by Chris Adams 14 years ago.
Git-generated patch

Download all attachments as: .zip

Change History (10)

by Chris Adams, 14 years ago

Attachment: Screen shot 2010-12-08 at 11.19.18 AM.png​ added

Example of overflow (IE8)

by Chris Adams, 14 years ago

Attachment: Screen shot 2010-12-08 at 11.33.59 AM.png​ added

Example with the change (IE8)

by Chris Adams, 14 years ago

Attachment: admin-recent-actions-text-overflow.patch​ added

Git-generated patch

comment:1 by Chris Adams, 14 years ago

Keywords: easy-pickings added; admin removed
Owner: changed from nobody to Chris Adams
Status: new → assigned

comment:2 by Jannis Leidel, 14 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Jannis Leidel, 14 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Jannis Leidel, 14 years ago

Resolution: → fixed
Status: assigned → closed

(In [14892]) Fixed #14868 -- Added CSS rule to prevent long text from overflowing the "recent actions" box on the admin index page. Thanks, Chris Adams.

comment:5 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

comment:6 by Loic Bistuer <loic.bistuer@…>, 11 years ago

In 33fc083b0db392bd35bc9d5d9a141adb25537253:

Fixed overflow for the "Recent Actions" widget on the admin index.

Previously the CSS targeted "li.changelink" and therefore didn't
work for the "add" and "delete" actions.

Refs #14868.

comment:7 by Tim Graham <timograham@…>, 11 years ago

In 39db994790d3e98b7558618c3dbfb2163e1a530c:

[1.6.x] Fixed overflow for the "Recent Actions" widget on the admin index.

Previously the CSS targeted "li.changelink" and therefore didn't
work for the "add" and "delete" actions.

Refs #14868.

Backport of 33fc083b0d from master

Note: See TracTickets for help on using tickets.
Back to Top