#14857 closed Uncategorized (duplicate)
has_results cleanup
| Reported by: | Waldemar Kornewald | Owned by: | nobody |
|---|---|---|---|
| Component: | Uncategorized | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The attached patch moves the SQL-specific code (just three lines) from sql.Query to SQLCompiler. This allows to override the has_results() behavior in the backend which is needed for NoSQL support. It would be nice if you could commit the patch. Thanks!
Attachments (1)
Change History (5)
by , 14 years ago
| Attachment: | has_results.diff added |
|---|
comment:2 by , 14 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
| Summary: | [patch] has_results cleanup → has_results cleanup |
Sorry - not a duplicate -- pasted a comment into the wrong tab.
However, I'm going to mark this wontfix. NoSQL support isn't something that needs to be addressed piecemeal. This isn't the only place that raw SQL leaks out of the compiler; these leaks need to be addressed as a whole, not piecemeal. As I've told you *many* times Waldemar, NoSQL support is on my radar for 1.4, when we address merging Alex's query-refactor SoC branch.
comment:3 by , 14 years ago
Note that query-refactor doesn't contain anything that doesn't already exist in Django-nonrel, so I'd appreciate if you could at least take a look at Django-nonrel before you merge query-refactor (which BTW needs some more work). Anyway, I've started documenting all existing and missing changes in NoSqlSupport.
comment:4 by , 11 years ago
| Easy pickings: | unset |
|---|---|
| Resolution: | wontfix → duplicate |
| Severity: | → Normal |
| Type: | → Uncategorized |
| UI/UX: | unset |
Duplicate of #17339 which has been merged.
patch against trunk