django.utils.formats localize_input inserts thousands_separator into boolean values

[Klaas van Schelven]

formats.localize_input(True)

I'm working in an environment where I've localized all my forms (set localize=True on all fields). I also have the USE_THOUSAND_SEPARATOR = True.

This results the value attr in my booleanfield to be set to "T,rue" (Dutch) or "T.rue" (US).

The ultimate culprit is django.utils.formats localize_input

There is a check there like so:

    if isinstance(value, (decimal.Decimal, float, int, long)):

which evaluates to True for Booleans (because booleans are ints, see "issubclass(bool, int)")

I do not currently have the time to provide tests etc. I do have a simple patch

[Klaas van Schelven]

• Added a patch, including a test this time. And still returning unicode for booleans (just not broken unicode)
• Turns out the problem also surfaces in more general settings (i.e. just printing booleans on screen).

[Jannis Leidel]

Needs to be backported, too.

[Russell Keith-Magee]

(In [14804]) Fixed #14807 -- Ensure that boolean values aren't localized as T.rue and Fa.lse because of the thousand separator. Thanks to vanschelven for the report and patch.

[Russell Keith-Magee]

(In [14807]) [1.2.X] Fixed #14807 -- Ensure that boolean values aren't localized as T.rue and Fa.lse because of the thousand separator. Thanks to vanschelven for the report and

Backport of r14804 from trunk.

[Jacob]

Milestone 1.3 deleted

[klaas@…]

When fixing this, input_localize was missed. My proposed solution (which is unfortunately not formatted as a pull request, nor does it have tests) is here:

​https://github.com/vanschelven/django/commit/f0e39c83ec9174b8e5241caa6ba59b8e2e6deb66

Also copying my notes from that solution to justify reopening the issue:

6c53a81 only fixed localize(), but not localize_input()
It appears to me that this was simply an oversight at the time.

It seems that a new call-order for fields somewhere between Django 1.4
and Django 1.6 triggers triggers this bug again, but this time on the inputs
and only when rendering fields as_hidden.

[Tim Graham]

I'll be better to open a new ticket rather than reopening one that's three years old where the original fix has already been released, thanks.

[Klaas van Schelven]

So was the new ticket created? Or am I expected to do this?

[Tim Graham]

Please do it, thank-you.

[Tim Graham]

The follow up ticket is #26173.

[Claude Paroz <claude@…>]

In 68407e35:

Refs #14807 -- Removed unneeded mark_safe call

[Claude Paroz <claude@…>]

In f6ea7c13:

[2.0.x] Refs #14807 -- Removed unneeded mark_safe call

Backport of 68407e3545f4b3e051c87cd530c97765bf2cdd80 from master.