WeekArchiveView gives incorrect results when using weeks beginning with Monday

[Mark Sundstrom]

WeekArchiveView defaults to weeks defined as beginning on Sunday (the strptime '%U' format) and this works correctly. Using weeks defined as beginning on Monday ('%W'), gives incorrect results. This is because BaseWeekArchiveView.get_dated_items calls the helper function, _date_from_string, with the wrong format.

For example, for the 10th week in 2009, beginning on Sunday, it correctly constructs the following:

time.strptime('2009__0__10', '%Y__%w__%U')

However, for the 10th week in 2009, beginning on Monday, it incorrectly constructs:

time.strptime('2009__0__10', '%Y__%w__%W')

This can be fixed by using:

time.strptime('2009__1__10', '%Y__%w__%W')

The '1' refers to the day of the week being Monday (Sunday = 0).

I've attached a patch, tests.diff, which demonstrates the problem, and another patch, dates.diff, with the correction.

[Łukasz Rekucki]

The patch looks ok, but both tests and the fix should be in a single diff - it's easier to test that way.

[Mark Sundstrom]

Replying to lrekucki:

The patch looks ok, but both tests and the fix should be in a single diff - it's easier to test that way.

Okay, see combined.diff

I had separated them because I thought it would be easier to demonstrate the problem, i.e.: apply the test patch, see the bug, apply the fix, see the bug go away.

[Russell Keith-Magee]

(In [14684]) Fixed #14752 -- Corrected date parsing in WeekArchiveView when using %W as a week format. Thanks to msundstr for the report and patch.

[Jacob]

Milestone 1.3 deleted