CZBirthNumberField expects two arguments to clean()

[Idan Gazit]

See ​cz/forms.py, line 53. The field's clean() takes two arguments, but clean() should only take one (value).

From looking at the source, it seems that the conditional block on L72 can simply be excised along with the invalid_gender error message. Without explicit knowledge of the associated gender, it looks like the additional gender-based validation logic isn't possible.

[Idan Gazit]

Looking at this some more, it seems like a nice solution would be to use a ComboField, consisting of two charfields: one for the number, one for the gender. Most of the validation that takes place today would happen on the ID number field. The gender charfield would simply validate that the value is either "m" or "f". The combofield's validation would take care of the interaction between the two.

Talked this idea over with alex_gaynor on IRC, he liked it, generally.

[Honza Král]

gender is not necessary to determine whether a birth number is valid, it just validates some further restrictions and shouldn't be part of the field's validation. It should remain for some time with a deprecation warning and will be removed in the future (probably replaced by a method that anybody can call manually from their form.clean for convenience).

[Idan Gazit]

Deprecate gender checking in clean()

[Idan Gazit]

Above patch issues the agreed-upon warning, new unittest updated to silence said warning: ​https://github.com/idangazit/django/compare/cz_clean_fix#diff-1

[Honza Král]

(In [15048]) Fixed #14593 -- Deprecating CZBirthNumberField's second argument to clean()

Gender is not necessary to determine whether a birth number is valid, it
just validates some further restrictions and shouldn't be part of the
field's validation.

[Jannis Leidel]

This needs to be a either PendingDeprecationWarning (and noted in the deprecation docs) or a backwards incompatible change (and noted in the release notes).

[Idan Gazit]

Oops, my bad. Preparing new patch with proper warning.

[Idan Gazit]

Changes issued warning to PendingDeprecationWarning

[Alex Gaynor]

(In [15062]) Fixed #14593 -- change this warning to be a PendingDeprecationWarning. Also converted the Czech localflavor tests to be unittests. We have always been at war with doctests. Thanks to Idan Gazit.

[Jacob]

Milestone 1.3 deleted

[Claude Paroz]

In [17939]:

Removed deprecated gender check in cz localflavor. Refs #14593.