Regression in FormWizard

[Timothée Peignier]

It seems that changeset [14291] introduced a regression in FormWizard.
The last form of the wizard is never passed to done(self, request, form_list) , that make FormWizard much useless.

Here is the regression test that should help :

def test_14291(self):
    reached = [False]
    that = self
        
    class WizardWithProcessStep(WizardClass):
        def done(self, request, form_list):
            reached[0] = True
            that.assertTrue(len(form_list) == 2)
        
    wizard = WizardWithProcessStep([WizardPageOneForm,
                                                                WizardPageTwoForm])
    
    data = {"0-field": "test",
                  "1-field": "test2",
                  "hash_0": "2fdbefd4c0cad51509478fbacddf8b13",
                  "wizard_step": "1"}
    wizard(DummyRequest(POST=data))
    self.assertTrue(reached[0])

[Timothée Peignier]

Regression test as a patch

[steph]

Patch and tests

[steph]

.. just added a patch to fix the problem.

[Luke Plant]

(In [14574]) Fixed #14576 - FormWizard.done() method doesn't get passed the last form in the list

Thanks to cyberdelia for report and test, and steph for the initial patch.

[Ramiro Morales]

(In [15044]) [1.2.X] Fixed #14576, #14946 - FormWizard.done() method doesn't get passed the last form in the list.

Thanks to cyberdelia for report and test, and steph for the initial patch.

Backport of r14574 from trunk.

[zyga]

This bug is not fixed properly.

Instead of appending a fresh instance of the last form (using get_form()) it should just append the "form" variable as that is the already created instance of the last form and it has been validated.

The solution currently applied for 1.3 breaks accessing cleaned_data.

[zyga]

On deeper inspection this is actually fixed properly in trunk, the patch attached to this bug is just wrong.

[Jacob]

Milestone 1.3 deleted