Opened 14 years ago

Closed 14 years ago

#14425 closed (fixed)

Unused imports in contrib.admin

Reported by: Rob Hudson Owned by: Chris Beaven
Component: contrib.admin Version: 1.2
Severity: Keywords:
Cc: Chris Long Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Attached is a patch which removes unused imports in all contrib.admin files. The tests continue to pass.

Attachments (1)

admin_imports.diff​ (6.1 KB ) - added by Rob Hudson 14 years ago.

Download all attachments as: .zip

Change History (6)

by Rob Hudson, 14 years ago

Attachment: admin_imports.diff​ added

comment:1 by Chris Beaven, 14 years ago

Component: Uncategorized → django.contrib.admin
Has patch: set
Owner: changed from nobody to Chris Beaven
Status: new → assigned
Triage Stage: Unreviewed → Ready for checkin

comment:2 by Chris Beaven, 14 years ago

Resolution: → fixed
Status: assigned → closed

(In [14175]) Fixed #14425 -- Unused imports in contrib.admin. Thanks robhudson.

comment:3 by Chris Long, 14 years ago

Resolution: fixed
Status: closed → reopened

This change breaks the example given in the admin actions documentation: ​http://docs.djangoproject.com/en/dev/ref/contrib/admin/actions/, specifically this line: selected = request.POST.getlist(admin.ACTION_CHECKBOX_NAME)

Should either add the line back to init.py: from django.contrib.admin.helpers import ACTION_CHECKBOX_NAME

Or change the documentation.

comment:4 by Chris Long, 14 years ago

Cc: Chris Long added

comment:5 by Chris Beaven, 14 years ago

Resolution: → fixed
Status: reopened → closed

Thanks clong, reverted in [14359].

Note: See TracTickets for help on using tickets.
Back to Top