Opened 14 years ago
Closed 8 years ago
#14284 closed New feature (wontfix)
Support for Google Maps version 3
| Reported by: | DaveWP196 | Owned by: | |
|---|---|---|---|
| Component: | GIS | Version: | dev |
| Severity: | Normal | Keywords: | Google Maps |
| Cc: | Alan Justino da Silva, kmike84@…, rh0dium, mr.kamu@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Rewrite the javascript files to use Google Maps V3 API rather than Google Maps V2 API. Google deprecated version 2 of the interface on 19 May 2010.
Attachments (3)
Change History (18)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
by , 14 years ago
| Attachment: | 14284_patch.diff added |
|---|
comment:4 by , 14 years ago
| Has patch: | set |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
| Patch needs improvement: | set |
comment:5 by , 14 years ago
Existing (broken) patch improved. Tested over 1.2.4 and working OK.
Needs clean-up of some unneeded settings, but for now this settings remains as noops. Django API keeps the same too.
comment:6 by , 14 years ago
| Cc: | added |
|---|
(last anonymous is me. I forgot to login before comment, sorry)
by , 14 years ago
| Attachment: | googlemapsv3_r16044.diff added |
|---|
fixed issue with GImage code generation
comment:7 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → New feature |
comment:8 by , 13 years ago
| Cc: | added |
|---|---|
| Easy pickings: | unset |
| UI/UX: | unset |
comment:9 by , 13 years ago
There is any chance for this to be into 1.4 ??
What needs to be done?
I managed to easily port to 1.3.X branch, and I can expect it to be easily ported to 1.4 too.
comment:11 by , 11 years ago
| Cc: | added |
|---|---|
| Version: | 1.2 → master |
This ticket should also address ticket #13462.
comment:12 by , 11 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:13 by , 10 years ago
(Working at the djangounderthehood sprint)
The default is now openstreetmap, so most people won't see the problem.
We did verify that the v2 google api is indeed still used in the django/contrib/gis/templates/gis/google/google-maps.js.
Note: https://docs.djangoproject.com/en/dev/ref/contrib/gis/admin/#django.contrib.gis.admin.GeoModelAdmin.map_template does mention you can change the map template, but it doesn't document which template to use for google.
An option could be to remove the google template altogether. Do we want to spend the time fixing the google template?
comment:14 by , 10 years ago
It all depends on user's interest. FWIW, I'm not. But if anyone provides a good patch with tests and docs, I'll take the time to review it.
If it is really broken and noone intends to take the time to update it, then yes, it would be better to remove it.
comment:15 by , 8 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
I'm going to remove contrib.gis.maps in #26697. I'm putting a link to this ticket in the release notes so if anyone is actually still using it, they can alert us.
First draft of patch to update from google maps v2 to v3. No testing performed for code.