Opened 14 years ago
Closed 14 years ago
#13829 closed New feature (wontfix)
EMAIL_CHARSET setting
| Reported by: | Ian Lewis | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Mail) | Version: | 1.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Add a EMAIL_CHARSET setting that allows you set the default encoding for emails.
Attachments (2)
Change History (7)
by , 14 years ago
| Attachment: | email_charset.patch added |
|---|
comment:1 by , 14 years ago
The setting defaults to the DEFAULT_CHARSET for ease of use and backwards compatibility.
by , 14 years ago
| Attachment: | email_charset_with_option.patch added |
|---|
A version of the patch which adds an encoding option to send_mail().
comment:2 by , 14 years ago
| Patch needs improvement: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
The feature looks valid and the patch looks ok in visual inspection. It's not applying anymore because doctests were converted to unittests. If somebody updates the test cases, this looks like something to check in.
Flagging as "Accepted" until tests are rewritten
comment:4 by , 14 years ago
| Severity: | → Normal |
|---|---|
| Type: | → New feature |
comment:5 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Is an email specific encoding still needed, different from DEFAULT_CHARSET? And is it a common enough case to warrant it's own setting?
I think it's rare enough that we can use EmailMessage (which does support setting the encoding) directly in those cases. Given that there's been no activity in 6 months, and the patch would need updating anyway, I'm going to close. Please re-open as needed.
Patch for the EMAIL_CHARSET setting.