Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#13686 closed (fixed)

Asymmetry in memcached.add and memcached.set

Reported by: Ned Batchelder Owned by: nobody
Component: Core (Cache system) Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In changeset [12637], conversions to and from utf-8 were removed from .set() and .get(). But .add() still performs the conversion, which seems wrong.

Attachments (2)

add-unicode.patch​ (1.2 KB ) - added by dmedvinsky 14 years ago.
Reattached patch from duplicate ticket by jbalogh
13686_14703_unicode_in_memcached_backend_r14757.diff​ (2.0 KB ) - added by Alexey Smolsky 14 years ago.
Extended patch with fix for #14703

Download all attachments as: .zip

Change History (8)

comment:1 by Russell Keith-Magee, 14 years ago

milestone: → 1.3
Triage Stage: Unreviewed → Accepted

comment:2 by Karen Tracey, 14 years ago

#13791 reported the same thing, and has a patch with a test.

by dmedvinsky, 14 years ago

Attachment: add-unicode.patch​ added

Reattached patch from duplicate ticket by jbalogh

comment:3 by dmedvinsky, 14 years ago

Has patch: set

by Alexey Smolsky, 14 years ago

Attachment: 13686_14703_unicode_in_memcached_backend_r14757.diff​ added

Extended patch with fix for #14703

comment:4 by Russell Keith-Magee, 14 years ago

Resolution: → fixed
Status: new → closed

In [15880]:

Fixed #13686 -- Ensure that memcache handling of unicode values in add() and set_many() is consistent with the handling provided by get() and set(). Thanks to nedbatchelder for the report, and to jbalogh, accuser and Jacob Burch for their work ont the patch.

comment:5 by Russell Keith-Magee, 14 years ago

In [15881]:

[1.2.X] Fixed #13686 -- Ensure that memcache handling of unicode values in add() and set_many() is consistent with the handling provided by get() and set(). Thanks to nedbatchelder for the report, and to jbalogh, accuser and Jacob Burch for their work ont the patch.

Backport of r15880 from trunk.

comment:6 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top