#13662 closed (fixed)
Documentation for running tests difficult to find
Reported by: | Michael Radziej | Owned by: | Greg Turner |
---|---|---|---|
Component: | Documentation | Version: | 1.2 |
Severity: | Keywords: | sprintdec2010 | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Somebody who just wants to run the django testsuite (and not actually contribute) will probably not look up "how to contribute" in the django docs, so he cannot find the documentation on how to run the testsuite. Please provide a simple explanation or refer to the docs in the toplevel README (as long as we cannot do a "setup.py test")
Attachments (3)
Change History (16)
comment:1 by , 14 years ago
milestone: | → 1.3 |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Patch attached and at https://github.com/cogat/django/commit/16e0b83c1ea18d9a5fab8bff4f7e754022c4d6f4.
I also updated the running tests documentation to be clearer and make it easier to get started.
comment:3 by , 14 years ago
Keywords: | sprintdec2010 added |
---|
comment:4 by , 14 years ago
by , 14 years ago
Attachment: | running_tests_docs.diff added |
---|
comment:5 by , 14 years ago
Has patch: | set |
---|
mostly looks good to me, spare a few little things:
I believe link on README line 44 should read:
http://docs.djangoproject.com/en/dev/internals/contributing/#running-the-unit-tests
(note the changed anchor)
I'm a bit concerned about telling people to install by manually putting this version in site-packages (docs/internals/contributing.txt, line 894). For the quick start, I've suggested simply symlinking django into the test directory (as well as pointed them to to the other options).
As an aside, these instructions could probably use to be updated (pip, anyone?)
I've uploaded a patch with the adding the new changes.
comment:7 by , 14 years ago
gg's patch applied at https://github.com/cogat/django/commit/6eca02df4091ea1ccf5b9c6b9f09ae84a85d9694
by , 14 years ago
Attachment: | 13662.combined.diff added |
---|
this patch contains all the changes from the above two patches, as well as a few extra line-length fixes
comment:9 by , 14 years ago
Owner: | removed |
---|---|
Status: | assigned → new |
comment:10 by , 14 years ago
Owner: | set to |
---|
comment:11 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Agreed; it's generally good practice to document how to run the tests as part of your README (or at least to provide a link to where such instructions are documented).