#13218 closed (fixed)
django-syndication can't handle https URLs
| Reported by: | schaefer | Owned by: | Ben Firshman |
|---|---|---|---|
| Component: | contrib.syndication | Version: | 1.1 |
| Severity: | Keywords: | ||
| Cc: | schaefer@…, Ben Firshman, skeen@…, clouserw@…, james@…, stephen.donner@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
django-syndication will always use an http scheme for feed URLs, even if the site is using https. This can cause problems when the site is only using https and redirects all http requests to a default page.
It seems to me that the main "culprit" here is add_domain:
source:django/trunk/django/contrib/syndication/views.py#L11
Attachments (1)
Change History (13)
comment:1 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 14 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
by , 14 years ago
| Attachment: | 13218.diff added |
|---|
comment:3 by , 14 years ago
| Has patch: | set |
|---|
comment:4 by , 14 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:6 by , 14 years ago
| Cc: | added |
|---|
comment:7 by , 14 years ago
| Cc: | added; removed |
|---|
Just checking on progress for this bug
I found that as mentioned, I could work around the generation of the <link> tag by providing the entire URL (including the https), But the syndication framework is generating the <atom:link on its own with the hard coded http scheme leading to rss validation errors
I'm new to the Django ticket triage process, but it looks like the next stage for this ticket is "ready for checkin". Let me know if there is anything I can do to help move this patch towards being landed.
thanks
comment:8 by , 14 years ago
| Cc: | added |
|---|
comment:9 by , 14 years ago
| Cc: | added |
|---|
comment:10 by , 14 years ago
| Cc: | added |
|---|
comment:11 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This isn't entirely true - syndication will honor https:// if it is provided in the links that are to be rendered. However, it is true that a feed will always assume that the URL scheme is HTTP, regardless of the request. The request scheme information is available when add_domain is called, so it should be used.