Display link to change-form on inlines where model is registered in admin site

[Simon Meers]

If an inline object has a get_absolute_url method, a 'View on site' link is displayed.

Here I propose that if an inline object is registered in the same admin site, an 'Edit' link is displayed in a similar fashion.

Why?

• The inline may only display a subset of fields, so the user may wish to go to the full change form
• 'Recursive inlines' can be accessed more easily -- e.g. Household has Person inlines, and Person has Phone inlines, etc.

The attached patch shows a draft implementation.

Questions:

• Do we need to check if the user has change permissions on that model before displaying the link? (in the unlikely event that the user has permission to change a model which displays the inlines of a model which they do not have change permissions for). Given that I cannot see a straightforward way of checking for this without the addition of a template tag/filter, and the rarity of such setups, I'd be happy to let the user click the link and get a permission denied page.
• Do we need an InlineModelAdmin option for enabling/disabling this link? E.g. InlineModelAdmin.show_admin_link. Or are we happy to have it enabled globally?
• Is [ Edit ] a sufficiently understandable link label? Would "Edit in Admin", or "Display full form" or something be more appropriate?

I think the reciprocal of this would also be very useful -- ForeignKey widgets could display an [edit] link beside the "add new" (green +) link which links to the change form for the selected parent object.

[Simon Meers]

InlineAdminForm changes, stacked/tabular template updates and regression tests

[Karen Tracey]

This is a feature request and thus not appropriate for the 1.2 milestone at this point.

[Russell Keith-Magee]

Sounds like a reasonable idea; reassigning to UX because it reflects on the UX of the admin, not admin code itself.

[Simon Meers]

Combined patch for #113163 and #13165

[Simon Meers]

Added unicode fix

[anonymous]

With Django 1.3 does not work. Is there anything like that under 1.3 ?

[patchhammer]

combined_13165_13165.diff fails to apply cleanly on to trunk

[Dominique PERETTI]

Add show_edit_link = True to your ObjectInline and you get an edit link

[Dominique PERETTI]

Hey guys, I've just added above my own implementation of this feature. Very simple, just 3 lines of code but does the job.
(This patch does it only in tabular.html).

class BooksInline(admin.TabularInline):
	model = Book
	show_edit_link = True

[Jacob]

Milestone 1.3 deleted

[anonymous]

any chance this will make it into 1.4 ?

[anonymous]

still waiting for this to become a feature.

[Simon Charette]

I packaged a simple app providing admin mixins to add a the edition and deletion links on all amin FK widgets, including those in inlines. You can find the project on ​github and on ​pypi.

[smcoll]

modifed version edit_inline_link.diff that supports inlined models from other apps

[Daniel Hahler]

@smcoll:

It looks like there is a wrong if in your patch: {% if inline_admin_form.original %}. It should check for the new show_edit_link option probably.

I assume that it won't work for many2many inlines, where you have model = Foo.bars.through?

[Nick Sandford]

PR here: ​https://github.com/django/django/pull/2957.

I added a method AdminSite.is_registered() which takes a Model class or lowercased model name. This is needed for checking if the InlineModelAdmin's model is also registered as a ModelAdmin on the site. There is precedence for this sort of check with registries -- the app registry has apps.is_installed(), and it seems to be a reasonable method to have on the AdminSite.

Renamed the show_edit_link to show_change_link for consistency across the admin. The link will only be displayed if show_change_link = True on the inline, the model itself is also registered, and there is an inline object to change.

[Nick Sandford]

Added docs, updated PR.

[Tim Graham <timograham@…>]

In 9d9f0acd7e245c9f9c30727a003666618754c924:

Fixed #13163 -- Added ability to show change links on inline objects in admin.

Thanks DrMeers for the suggestion.