Problem with selecting related object from popup window, opened by lens icon in dynamic created inline row

[ramusus]

With inline rows created by django's template everithing is ok, but I found problem with rows created dynamically. Problem with changing dynamic id in html containers of created row. Id of lens-icon-link defines incorrectly.

[ramusus]

this patch only changes .find("input,select,textarea,label") > .find("input,select,textarea,label,a")

[Stefan Foulis]

it seems that the numbering on some fields is off by one. it's tricky, because the rows are numbered starting with 1 in the visible parts and the class of the element that surrounds each row. But the actual id's on the rows of the formset start with 0.
Adding a '-1' in the right spot in inlines.js fixed issue for me (with dropdown foreignkeys, the '+' add button and the raw id widget).
I attached a patch.

[Stefan Foulis]

adds a '-1' in both inlines.js and inlines.min.js

[ramusus]

The problem is not a shift between number of row and id of elements inside this row for me. The problem is starting, when I create new rows dynamically and these rows has a lookup lens icon with link. Id for this link generated incorrectly and it's the reason of this ticket.

[Rob Hudson]

ramusus's patch made sense to me after reading the code. In the inlines.js there seems to be a cleanup method, updateElementIndex, and the anchor tag for the lens icon wasn't getting picked up by this method and its index wasn't correct. I will be attaching a patch, the same as ramusus, but without the extra spacing changes. This patch has been tested and works for me.

[Rob Hudson]

Adding 'a' to the list of dom elements updateElementIndex is passed.

[Jannis Leidel]

(In [12784]) Fixed #13026 - Also update the index of lookup links when adding inlines dynmacially in the admin. Thanks to ramusus and Rob Hudson for the patch.

[Jacob]

Milestone 1.2 deleted