Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#12878 closed (fixed)

Formset wide errors are not properly rendered in the template

Reported by: KyleMac Owned by: matiasb
Component: contrib.admin Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Errors raised by a FormSet's clean() method are converted straight to strings and rendered along the lines of "[u'This is an error.']" instead of being iterated over and styled properly.

Attachments (2)

12878-1.diff​ (2.0 KB ) - added by matiasb 15 years ago.
Fixed formsets to set non_form_errors as errorlist after a full_clean
12878-2.diff​ (2.8 KB ) - added by matiasb 15 years ago.
Updated previous patch to add general formset test

Download all attachments as: .zip

Change History (9)

comment:1 by Russell Keith-Magee, 15 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by matiasb, 15 years ago

Owner: changed from nobody to matiasb
Status: new → assigned

by matiasb, 15 years ago

Attachment: 12878-1.diff​ added

Fixed formsets to set non_form_errors as errorlist after a full_clean

comment:3 by matiasb, 15 years ago

Has patch: set

added patch

by matiasb, 15 years ago

Attachment: 12878-2.diff​ added

Updated previous patch to add general formset test

comment:4 by Alex Gaynor, 15 years ago

milestone: → 1.2
Triage Stage: Accepted → Ready for checkin

comment:5 by jkocherhans, 15 years ago

Resolution: → fixed
Status: assigned → closed

(In [12548]) Fixed #12878. Formset-wide errors are now rendered properly as html.

comment:6 by jkocherhans, 15 years ago

(In [12549]) [1.1.x] Fixed #12878. Formset-wide errors are now rendered properly as html. Backport of r12548 from trunk.

comment:7 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top