Localflavor bad arguments handling

[Sayane]

A lot of form fields in django.contrib.localflavor handles arguments to __init__() in a bad way.

    def __init__(self, *args, **kwargs):
        super(PLPESELField, self).__init__(r'^\d{11}$',
            max_length=None, min_length=None, *args, **kwargs)

Every line like first one should be fixed like this:

    def __init__(self, max_length=None, min_length=None, *args, **kwargs):

Because if someone will pass max_length or min_length argument to __init__() it will fail (multiple min_length/max_length arguments - additional one will be in kwargs).

It is a big problem, if i'm trying to do something like this:

class PostalCodeField(models.CharField):
    def formfield(self, **kwargs):
        kwargs.setdefault("form_class", PLPostalCodeField)
        return super(self.__class__, self).formfield(**kwargs)

because django.db.models.CharField sets max_length to self.max_length.

I'm attaching patch to fix polish localflavor.

[Claude Paroz]

I basically see what's the problem and what to do. Now there is a lot of similar changes to make, and I would like to know if I'm going in the right direction before giving more time to this.

See my patch, and tell me if it's OK (and good practice) to pass max_length and min_length to super as args (vs kwargs).
For tests, should I add field_kwargs to all tests, or add a second assert with field_kwargs to all tests, or simply add field_kwargs once per test case?

[Claude Paroz]

OK, fixed now in all localflavors. Tested in utils.assertFieldOutput.

[Jannis Leidel]

In [16146]:

Fixed #12595 -- Fixed bad arguments handling in localflavor form fields.