Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#12367 closed (fixed)

Test suite raises deprecation warning for URLConf using admin.site.root.

Reported by: Cliff Dyer Owned by: Cliff Dyer
Component: Testing framework Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Part of the test suite still uses admin.site.root, and is raising DeprecationWarnings during the running of the test suite.

See, for instance, django/tests/regressiontests/generic_inline_admin/urls.py and django/tests/regressiontests/admin_widgets/urls2.py. I suspect neither of these are actively testing admin.site.root, so they should be updated to use the new method. If the old method needs to be tested, (and maybe it already is) the test should handle the DeprecationWarning, rather than letting it fall through to the test runner.

Attachments (1)

12367.diff​ (932 bytes ) - added by Travis Cline <travis.cline@…> 15 years ago.

Download all attachments as: .zip

Change History (4)

by Travis Cline <travis.cline@…>, 15 years ago

Attachment: 12367.diff​ added

comment:1 by Travis Cline <travis.cline@…>, 15 years ago

Has patch: set
Triage Stage: Unreviewed → Accepted

Attached a patch that updates the urlconfs, not sure if there's value in testing .root

comment:2 by Russell Keith-Magee, 15 years ago

Resolution: → fixed
Status: new → closed

(In [11861]) Fixed #12367 -- Modified test urls to avoid the DeprecationWarning caused by old-style admin inclusions. Thanks to Travis Cline for the patch.

comment:3 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top