Opened 19 years ago

Closed 19 years ago

Last modified 16 years ago

#1235 closed defect (fixed)

[patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''

Reported by: igor@… Owned by: Adrian Holovaty
Component: Core (Other) Version:
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I think it would be very useful if it was possible to send e-mail (using 'django.core.mail') in something different than 'us-ascii', for example, in 'utf-8' by default (using DEFAULT_CHARSET variable).

The patch will be included.

Attachments (2)

django-mail-charset-support.diff​ (1.2 KB ) - added by igor@… 19 years ago.
patch for support different charsets in mail messages
django-mail-charset-support.2.diff​ (1.1 KB ) - added by Antti Kaihola 19 years ago.
magic-removalized version of the patch, with Header() import

Download all attachments as: .zip

Change History (18)

by igor@…, 19 years ago

Attachment: django-mail-charset-support.diff​ added

patch for support different charsets in mail messages

comment:1 by hugo, 19 years ago

what is this Header() call you are using? Shouldn't it be imported from somewhere (or defined somehow)? Can't find it in the core/mail.py or in your patch.

comment:2 by igor@…, 19 years ago

Arhhh. Very sorry.

Forgot to include importion of email.Header.Header:

from email.Header import Header

comment:3 by hugo, 19 years ago

Ok. That one does handle quoted-printable-encoding correctly, so I am +1 on this patch.

comment:4 by alex.smudgy@…, 19 years ago

And when can we wait for patch in django-release ?

by Antti Kaihola, 19 years ago

Attachment: django-mail-charset-support.2.diff​ added

magic-removalized version of the patch, with Header() import

comment:5 by akaihola <antti.kaihola@…>, 19 years ago

Summary: Django can't send e-mail in other encoding than 'us-ascii' → [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii'

comment:6 by Adrian Holovaty, 19 years ago

priority: normal → low
Severity: normal → minor

comment:7 by igor@…, 19 years ago

Adrian, why is it a minor/low issue? Please believe me it is very important for people who use not only latin1 charset (i.e. Russians).

When this patch will appear in the mainstream?

Thank you.

comment:8 by dottedmag@…, 19 years ago

I also don't think that ignoring everyone except English-speaking people is the 'minor' issue with 'low' priority. It's even not Latin1 charset which would be ok for some europeans, it is US-ASCII, which is sufficient only for English.

comment:9 by unatine@…, 19 years ago

When this patch appear in trunk?
It's very important for non-English speaking users.

comment:10 by timochka@…, 19 years ago

I want messages in UTF-8! I'm +1 for this patch

comment:11 by mblsha, 19 years ago

It would be cool to support unicode when sending mail, so Django would be on par with Rails in this case.

comment:12 by Jacob, 19 years ago

What, did you guys organize a write-in campaign or something? :)

comment:13 by Jacob, 19 years ago

Resolution: → fixed
Status: new → closed

(In [2901]) Fixed #1235: email sent from django.core.mail will now be encoded using
the value of the DEFAULT_CHARSET setting. Thanks, igor@… and akaihola.

comment:14 by anonymous, 18 years ago

Summary: [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii' → [patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''

comment:15 by call_of_duty_6, 16 years ago

hello! thank you for veru userfull info. see also here *​rapidshare file search

in reply to:  15 comment:16 by call_of_duty_6, 16 years ago

Replying to call_of_duty_6:

see also here *​rapidshare file search

Note: See TracTickets for help on using tickets.
Back to Top