django.contrib.gis.gdal.OGRGeometry leaking memory

[nino@…]

gdal.OGRGeometry from WKB and WKT leaks memory like crazy (using GDAL 1.6.0, on debian). Reference counts do not appear to go up, but memory climbs rapidly.

From WKB:

from django.contrib.gis.geos import Point
from django.contrib.gis import gdal

geom = Point(1,1)
geom.srid = 4326
for i in xrange(1000000):
   g = gdal.OGRGeometry(geom.wkb, geom.srid)
   del g

From WKT:

from django.contrib.gis.geos import Point
from django.contrib.gis import gdal

geom = Point(1,1)
geom.srid = 4326
for i in xrange(1000000):
   g = gdal.OGRGeometry(geom.wkt, geom.srid)
   del g

[jbronn]

I've confirmed this is as a bug, the leak is real. I think it's within the SpatialReference code because there's no balloon in memory usage when I change to this:

for i in xrange(1000000):
   g = gdal.OGRGeometry(geom.wkt)
   del g

[jbronn]

Fixes memory leak when assigning SpatialReference to OGRGeometry

[jbronn]

I've come up with a patch that works, and all tests pass with it. However I can't fully explain yet why it works over the previous version, other than that somehow the cloned SpatialReference object references (within OGR, not Python) were not being released. As soon as I can explain why those references were not being released, I'll commit the patch.

[jbronn]

(In [11708]) [1.1.X] Fixed #12101 -- OGRGeometry does not need to create a clone of the SpatialReference object upon assignment.

Backport of r11707 from trunk.

[Jacob]

Milestone 1.2 deleted