#11972 closed (fixed)
Title filter should not capitalize ordinals
| Reported by: | Owned by: | Karen Tracey | |
|---|---|---|---|
| Component: | Template system | Version: | 1.1 |
| Severity: | Keywords: | title filter | |
| Cc: | Gonzalo Saavedra | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The main problem I have with the title filter is that if you have, say, an address "555 WEST 53RD STREET", and you want to run it through a title filter, you get "555 West 53Rd Street". The letters coming after the digits should not be capitalized.
Just like the title filter special cases for apostrophes (making sure JOE'S CRAB SHACK doesn't turn into Joe'S Crab Shack), it should also lower letters coming directly after numbers.
Attachments (2)
Change History (11)
by , 15 years ago
| Attachment: | title_filter_ordinal_patch.diff added |
|---|
comment:1 by , 15 years ago
| Cc: | added |
|---|
comment:2 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 15 years ago
comment:4 by , 15 years ago
| Needs tests: | set |
|---|---|
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
I've confirmed the problem, and have written a unit test. I'll submit a new patch that will include the test as well.
comment:5 by , 15 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | unset |
w00t. Here is a patch with a test.
schwank@…: Thanks for the patch! One thing to note, if you svn diff from the trunk directory, then the patch will contain the full path to the file(s) it patches, which makes it a little simpler to apply. Looks good!
comment:6 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
| Triage Stage: | Accepted → Ready for checkin |
Hey Karen, here's my first ever Django submission!
comment:7 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
This patch needs a unit test too. Working on it!