The attributes of the original get_absolute_url defined in the model is not copied

[Nils Fredrik Gjerull]

I have made an app that assist in purging upstream web caches and it uses, among other methods, get_absolute_url. Because I don't always want to purge based on get_absolute_url I added an attribute to get_absolute_url named purge. This attribute gets lost because get_absolute_url is changed with the get_absolute_url that do absolute url overrides, curried with the original function. The original function's attributes should be added to the new curried function.

class AModel(models.Model):
    def get_absolute_url(self):
        return '/some_url/'
    get_absolute_url.purge = True

[Nils Fredrik Gjerull]

Preserve attributes of the original get_absolute_url method

[Russell Keith-Magee]

(In [12766]) Fixed #11891 -- Ensured that attributes of get_absolute_url are preserved through the metaclass. Thanks to nfg for the report and patch.

[Russell Keith-Magee]

(In [12767]) [1.1.X] Fixed #11891 -- Ensured that attributes of get_absolute_url are preserved through the metaclass. Thanks to nfg for the report and patch.

Backport of r12766 from trunk.

[Karataev Pavel]

need to fix models.permalink decorator

and #12836 market as duplicate

[James Bennett]

The fix in [12766] included unit tests to check that this works, and the tests pass; without proof that the fix didn't actually work, this shouldn't be reopened.

[Karataev Pavel]

copy & paste from #12836

class MyModel(models.Mode):
    @models.permalink
    @set_attr('x', 10) # set some attribute to MyModel.get_absolute_url method
    def get_absolute_url(self):
        return ('some', (self.attr, ))

>>>print MyModel().get_absolute_url.x
AttributeError: 'function' object has no attribute 'x'

[Carl Meyer]

The problem here is that #12836 shouldn't have been closed as dupe in the first place. This ticket is about problems with the replacement of get_absolute_url in ModelBase, which is now fixed. #12836 is about @models.permalink not updating wrappers, which is a valid, but separate issue. Re-closing this as fixed, reopening #12836.

[Jacob]

Milestone 1.2 deleted