ModelAdmin.get_changelist_form should use ModelAdmin.form

[Eduardo de Oliveira Padoan]

When you create a ModelForm to associate with a ModelAdmin, using the 'form' option, this form will not be used on the list_editable form. When I define a .clean() method, I'd like the validation to work both on the changeform and on the changelist.

A quick fix:

     def get_changelist_form(self, request, **kwargs):
         defaults = {
+            "form": self.form,
            "formfield_callback": curry(self.formfield_for_dbfield,
                                              request=request),
         }
         defaults.update(kwargs)
         return modelform_factory(self.model, **defaults)

[Luke Plant]

That's a really bad idea, and would cause lots of breakages, because many people will be assuming that the Form they have created will be used only for the change form, and not the change list. We need a new attribute like 'changelist_form', if anything.

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Yeago]

I agree with lukeplant and yet with raw_id_fields, here we are creating an admin option which affects both.

[Julien Phalip]

See related issue in #11651.

[anonymous]

Any updates on this ?

[pwbdecker@…]

Presently to add validation to the change list form I have to override get_changelist_form to return my custom form. I would also like to see the option to be able to use the admin options form.

[Jacob]

I'm with Luke: this isn't something we should change; the downsides outweigh the upsides.