PLNIPField validation error when empty

[amz]

PLNIPField from [source:django/trunk/django/contrib/localflavor/pl/forms.py] doesn't validate when not required:

Exception Type:	IndexError
Exception Value:	string index out of range
Exception Location:	/usr/lib/python2.5/site-packages/django/contrib/localflavor/pl/forms.py in has_valid_checksum, line 96

Re create:

class Client(models.Model):
    name = models.CharField(max_length=200, blank=True)
    nip = models.CharField(max_length=13, blank=True)

class ClientForm(forms.ModelForm):
    nip = PLNIPField(required=False)

Suggestion: Don't validate if submited date is empty (patch attached)

---

[Alex Gaynor]

Not a 1.0.3 ticket.

[anonymous]

This ticket is sitting for over a year, maybe it will be good to accept it? ;)

[anonymous]

Ding dong, someone is really (try to) using it. Can you accept this ticket?

[Łukasz Rekucki]

Replying to anonymous:

Ding dong, someone is really (try to) using it. Can you accept this ticket?

It is accepted, but not ready for inclusion. First, it needs tests. Second, it doesn't fix the problem entirely. A string like "---" will pass the length check, then get stripped and an empty string will be passed to has_checksum_valid.

[Claude Paroz]

Apparently fixed by changeset:14949